----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68278/#review207025 -----------------------------------------------------------
src/java/org/apache/sqoop/Sqoop.java Lines 95 (patched) <https://reviews.apache.org/r/68278/#comment290185> You could extract SqoopVersion into a local variable and reuse it. - Fero Szabo On Aug. 9, 2018, 1:32 p.m., Nguyen Truong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68278/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2018, 1:32 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3359 > https://issues.apache.org/jira/browse/SQOOP-3359 > > > Repository: sqoop-trunk > > > Description > ------- > > I added a log message for the git hash of the running Sqoop in the debug > level. > > > Diffs > ----- > > src/java/org/apache/sqoop/Sqoop.java > 08ff82ca22cb2fcdffeb29661951d091a70c5bb9 > > > Diff: https://reviews.apache.org/r/68278/diff/1/ > > > Testing > ------- > > > Thanks, > > Nguyen Truong > >
