----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68278/#review207030 -----------------------------------------------------------
Hi Nguyen, Thank you for submitting this patch, it is a nice little improvement for debugging. I have left a minor comment, please take a look. Szabolcs src/java/org/apache/sqoop/Sqoop.java Lines 95 (patched) <https://reviews.apache.org/r/68278/#comment290190> I have just realized that VERSION and GIT_HASH are static final members of SqoopVersion so the best practice is to access them via class reference: SqoopVersion.VERSION SqoopVersion.GIT_HASH - Szabolcs Vasas On Aug. 9, 2018, 1:53 p.m., Nguyen Truong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68278/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2018, 1:53 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3359 > https://issues.apache.org/jira/browse/SQOOP-3359 > > > Repository: sqoop-trunk > > > Description > ------- > > I added a log message for the git hash of the running Sqoop in the debug > level. > > > Diffs > ----- > > src/java/org/apache/sqoop/Sqoop.java > 08ff82ca22cb2fcdffeb29661951d091a70c5bb9 > > > Diff: https://reviews.apache.org/r/68278/diff/2/ > > > Testing > ------- > > > Thanks, > > Nguyen Truong > >
