----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67407/#review208551 -----------------------------------------------------------
Ship it! Hi Chris, Thank you for submitting this patch, I have successfully executed the unit and third party tests, I am not really familiar with the technical background of the mainframe migrated data sets but based on the examples given in the code it should be OK. I have left only one comment regarding the code style. Regards, Szabolcs src/java/org/apache/sqoop/mapreduce/mainframe/MainframeFTPFileEntryParser.java Lines 117 (patched) <https://reviews.apache.org/r/67407/#comment292572> I think this block could be extracted into a separate method just, it would make parseFTPEntry more readable. - Szabolcs Vasas On June 1, 2018, 11:57 p.m., Chris Teoh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67407/ > ----------------------------------------------------------- > > (Updated June 1, 2018, 11:57 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-trunk > > > Description > ------- > > Mainframe FTP needs to Include "Migrated" datasets when parsing the FTP list. > Initially, these were excluded out of the regular expression. > > > Diffs > ----- > > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeFTPFileEntryParser.java > f0b87868 > > src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeFTPFileEntryParser.java > eb0f8c00 > > > Diff: https://reviews.apache.org/r/67407/diff/4/ > > > Testing > ------- > > Unit testing. > > > Thanks, > > Chris Teoh > >
