----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67407/#review209253 -----------------------------------------------------------
Fix it, then Ship it! Hi Chris, Thanks for this patch! Unit and 3rd party tests passed for me but I have a minor finding regarding file formatting, please take a look. Thank you, Bogi src/java/org/apache/sqoop/mapreduce/mainframe/MainframeFTPFileEntryParser.java Lines 32-35 (original), 32-45 (patched) <https://reviews.apache.org/r/67407/#comment293556> Indentation is not aligned with the one used in this file, this applies to the further lines too. - Boglarka Egyed On Sept. 21, 2018, 10:40 a.m., Chris Teoh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67407/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2018, 10:40 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-trunk > > > Description > ------- > > Mainframe FTP needs to Include "Migrated" datasets when parsing the FTP list. > Initially, these were excluded out of the regular expression. > > > Diffs > ----- > > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeFTPFileEntryParser.java > f0b87868 > > src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeFTPFileEntryParser.java > eb0f8c00 > > > Diff: https://reviews.apache.org/r/67407/diff/5/ > > > Testing > ------- > > Unit testing. > > > Thanks, > > Chris Teoh > >
