Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/268#discussion_r19088253
--- Diff: storm-core/src/clj/backtype/storm/daemon/worker.clj ---
@@ -330,6 +330,20 @@
(.send drainer node+port->socket)))
(.clear drainer))))))
+;; Check whether this messaging connection is ready to send data
+(defn is-connection-ready [^IConnection connection]
+ (if (instance? ConnectionWithStatus connection)
--- End diff --
Yes, if we change IConnection to add method status(), subclasses of
IConnection should implement it. It means all of subclasses needs change.
We can discuss it more with contributors / committers to decide we can
break compatibility to make it more clearer, or keep compatibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
