[ 
https://issues.apache.org/jira/browse/STORM-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203829#comment-14203829
 ] 

Itai Frenkel commented on STORM-528:
------------------------------------

[~revans2] Remeber that the storm.py is just a base class, and real production 
code we add alot of other py files that derive from it. Placing the 
python/ruby/nodejs files in a JAR would require  npm install/pip install/gem 
install as part of the maven build and package the dynamic code with all of its 
dependnecies. It is too combersome. 
The real solution IMO is to allow ShellBolts to override _codeDir and provide a 
path to the python/nodejs/code. We currently do that with reflection magic in 
our base classes.
That way the examples could specify where to find the dynamic code folder. and 
that's it.

> examples/storm-starter/multilang/resources/storm.py diverged
> ------------------------------------------------------------
>
>                 Key: STORM-528
>                 URL: https://issues.apache.org/jira/browse/STORM-528
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.9.2-incubating
>            Reporter: Itai Frenkel
>
> As we know storm.py is committed three times. One of these files (the one in 
> examples) have diverged from the other two. It also introduces some strange 
> behavior as it calls "log" instead of "error" when a bolt fails.
> I would recommend to override the storm/examples version with the one in 
> storm-core and then have the diff as a new pull request



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to