[ 
https://issues.apache.org/jira/browse/STORM-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301949#comment-14301949
 ] 

ASF GitHub Bot commented on STORM-528:
--------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/389#issuecomment-72539951
  
    There is a lot of code in here that I don't understand how it relates to 
STORM-528.  Setting the code dir, is not really something that I think we want 
to expose, except a controlled way for testing.  I also don't understand all of 
the code for max pending.  It looks like you have code from multiple JIRA here.


> examples/storm-starter/multilang/resources/storm.py diverged
> ------------------------------------------------------------
>
>                 Key: STORM-528
>                 URL: https://issues.apache.org/jira/browse/STORM-528
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.9.2-incubating
>            Reporter: Itai Frenkel
>            Assignee: Rekha Joshi
>
> As we know storm.py is committed three times. One of these files (the one in 
> examples) have diverged from the other two. It also introduces some strange 
> behavior as it calls "log" instead of "error" when a bolt fails.
> I would recommend to override the storm/examples version with the one in 
> storm-core and then have the diff as a new pull request



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to