GitHub user NareshKosgi opened a pull request:
https://github.com/apache/storm/pull/318
Storm-456 cannot navigate to topology page when name contains spaces
@Parth-Brahmbhatt
I had pull request open for this but I deleted it accidentally.
You were rite the decode only fixed the space issue but caused issues with
percent sign. After looking thru the code I found where the url is being
encoded and changed it to use the ring encoder. This fixed the issue for both
percent and space.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NareshKosgi/incubator-storm storm-456
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/318.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #318
----
commit e72a94c1de7dd4fa7744c9dd914439bcd59a634b
Author: Naresh Kosgi <[email protected]>
Date: 2014-10-18T02:57:52Z
routes look for the plus sign
commit ccbfad1fec3f99531a8160dae51419abc3e5bb87
Author: Naresh Kosgi <[email protected]>
Date: 2014-10-27T16:12:18Z
using word count to test
commit 757653d523a52a3c0dccec1dba55c951fce815c5
Author: Naresh Kosgi <[email protected]>
Date: 2014-10-27T23:36:52Z
Merge branch 'master' into storm-456
commit 5afb60a3fdabc849efe6e746d5672e1d6cb4f7a2
Author: Naresh Kosgi <[email protected]>
Date: 2014-11-11T21:23:52Z
added url decode method in the route
commit 31b1032a144d6ff020600c63093e6360629d830c
Author: Naresh Kosgi <[email protected]>
Date: 2014-11-11T21:27:45Z
Merge branch 'storm-456' of https://github.com/NareshKosgi/incubator-storm
into storm-456
Conflicts:
storm-core/src/clj/backtype/storm/ui/core.clj
commit ac4542a5a3dff54af65ab67394170072843b2f88
Author: Naresh Kosgi <[email protected]>
Date: 2014-11-11T21:34:07Z
changed word count Topo back to local cluster
commit 2a38a033e12d4f79ac022709280a5fc86902dc29
Author: Naresh Kosgi <[email protected]>
Date: 2014-11-11T21:35:32Z
changed Wordcount back to normal
commit 4ea7f01d2796b25f3fd8ca0f8d93407771b64adf
Author: Naresh Kosgi <[email protected]>
Date: 2014-11-11T21:37:59Z
reverting word count topo
commit 86c33e4e6c071ae88fb660be3599e217778dafd4
Author: Naresh Kosgi <[email protected]>
Date: 2014-11-18T19:27:12Z
using the ring encoder
commit 3ee031f65136d3a7cb29edf89568ce4d20647f3b
Author: Naresh Kosgi <[email protected]>
Date: 2014-11-18T19:33:45Z
Merge branch 'storm-456' of https://github.com/NareshKosgi/incubator-storm
into storm-456
Conflicts:
storm-core/src/clj/backtype/storm/ui/core.clj
commit 608f3e6b44bdbfe2da9c1eb9005c3c1b91027718
Author: Naresh Kosgi <[email protected]>
Date: 2014-11-18T19:34:18Z
deleted the generated pom
commit a5dbea06a543d04e3b4978a30e3a38fd17fb9731
Author: Naresh Kosgi <[email protected]>
Date: 2014-11-18T19:45:09Z
Merge branch 'master' into storm-456
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
