[ 
https://issues.apache.org/jira/browse/STORM-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256209#comment-14256209
 ] 

ASF GitHub Bot commented on STORM-599:
--------------------------------------

GitHub user d2r opened a pull request:

    https://github.com/apache/storm/pull/356

    [STORM-599] Use use nimbus's cached heartbeats rather than fetching again 
from ZK

    In my manual testing, this seems to cut the time to load a topology page by 
around 50%.
    
    This also removes some apparently unnecessary code.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/d2r/storm apache-use-hb-cache-for-topo-info

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #356
    
----
commit 3907b2d780b796e754bf3566d29567cff6e77679
Author: Derek Dagit <der...@yahoo-inc.com>
Date:   2014-12-13T15:36:31Z

    use the cache instead of downloading from zk

commit 40be5ddb94b674f8fcf2c804c7af96fbfe77776a
Author: Derek Dagit <der...@yahoo-inc.com>
Date:   2014-12-13T15:36:51Z

    Remove unnecessary code

----


> UI is slow due to fetching heartbeats from ZK
> ---------------------------------------------
>
>                 Key: STORM-599
>                 URL: https://issues.apache.org/jira/browse/STORM-599
>             Project: Apache Storm
>          Issue Type: Improvement
>    Affects Versions: 0.9.3
>            Reporter: Derek Dagit
>            Assignee: Derek Dagit
>            Priority: Minor
>
> The method getTopologyInfo fetches every heartbeat from ZooKeeper in order to 
> gather statistics.  The UI calls this method via thrift to render the 
> topology page.
> When topologies are launched with thousands of executors, this fetching from 
> ZK dramatically slows things down.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to