[
https://issues.apache.org/jira/browse/STORM-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257528#comment-14257528
]
ASF GitHub Bot commented on STORM-599:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/356#issuecomment-67997939
The changes look fine to me. My only concern would be around what happens
if the cache has not been updated and is empty, but it looks like it will
return an empty map, and that looks like what happened before when there were
no heartbeats.
+1
> UI is slow due to fetching heartbeats from ZK
> ---------------------------------------------
>
> Key: STORM-599
> URL: https://issues.apache.org/jira/browse/STORM-599
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.9.3
> Reporter: Derek Dagit
> Assignee: Derek Dagit
> Priority: Minor
>
> The method getTopologyInfo fetches every heartbeat from ZooKeeper in order to
> gather statistics. The UI calls this method via thrift to render the
> topology page.
> When topologies are launched with thousands of executors, this fetching from
> ZK dramatically slows things down.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
