[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271142#comment-14271142
]
ASF GitHub Bot commented on STORM-243:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r22720912
--- Diff: storm-core/pom.xml ---
@@ -464,6 +464,30 @@
</dependencies>
</plugin>
<plugin>
+ <groupId>org.codehaus.mojo</groupId>
--- End diff --
This code will not run on a build for Windows. I think it is going to
produce build errors if we try. I would like to see this placed in a profile
that is activated only for Operating systems that we know it works on. And file
a follow up JIRA to make this work on Windows.
https://maven.apache.org/guides/introduction/introduction-to-profiles.html
> Record version and revision information in builds
> --------------------------------------------------
>
> Key: STORM-243
> URL: https://issues.apache.org/jira/browse/STORM-243
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: caofangkun
> Assignee: caofangkun
> Priority: Minor
> Attachments: STORM-243-1.patch, ui.png
>
>
> The effect shown below,
> For Subversion project :
> $ storm version
> Storm 0.9.2-incubating-SNAPSHOT
> Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959
> Compiled by somebody on Wed Feb 19 11:23:38 CST 2014
> From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f
> or
> $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar
> backtype.storm.utils.VersionInfo
> Storm 0.9.2-incubating-SNAPSHOT
> Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959
> Compiled by somebody on Wed Feb 19 11:23:38 CST 2014
> From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f
> For Git Project:
> $ storm version
> ➜ storm-current storm version
> Running: ... ...
> Storm 0.10.0-SNAPSHOT
> Subversion https://github.com/caofangkun/apache-storm.git -r
> ffba148cc47a92185fa1a5db11f72982de10f106
> Branch storm-243
> Compiled by caokun on Thu Jan 8 10:47:48 CST 2015
> From source with checksum 97e7c942939e3e82dcb854b497991a51
> For UI
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
