[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257335#comment-14257335
]
ASF GitHub Bot commented on STORM-243:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r22228357
--- Diff: storm-dist/binary/src/main/assembly/binary.xml ---
@@ -131,13 +131,6 @@
</file>
<!-- TODO this should be a generated file from "target" -->
<file>
- <source>${project.basedir}/../../VERSION</source>
- <outputDirectory>/</outputDirectory>
- <destName>RELEASE</destName>
--- End diff --
There are explicit checks elsewhere in the code looking for the RELEASE
file. If it is not present some parts of the code assume they are not part of
a valid release.
https://github.com/caofangkun/apache-storm/blob/storm-243/bin/storm#L86-91
is one example of where this happens.
> Record version and revision information in builds
> --------------------------------------------------
>
> Key: STORM-243
> URL: https://issues.apache.org/jira/browse/STORM-243
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: caofangkun
> Assignee: caofangkun
> Priority: Minor
> Attachments: STORM-243-1.patch
>
>
> Patch atteThe effect shown below,
> $ storm version
> Storm 0.9.2-incubating-SNAPSHOT
> Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959
> Compiled by somebody on Wed Feb 19 11:23:38 CST 2014
> From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f
> or
> $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar
> backtype.storm.utils.VersionInfo
> Storm 0.9.2-incubating-SNAPSHOT
> Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959
> Compiled by somebody on Wed Feb 19 11:23:38 CST 2014
> From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
