Github user rick-kilgore commented on the pull request:
https://github.com/apache/storm/pull/254#issuecomment-69433393
@revans2 I made changes to address both your comments. Please have a look.
That's a good catch about how I was using Comparable - thanks!
By the way, I also have another branch on top of this one where I
refactored a few things to make the code more testable, and then added some
unit tests for PartitionManager.java. It's here:
https://github.com/HBOCodeLabs/incubator-storm/pull/4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
