Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/254#issuecomment-69598121
+1 the new changes look fine to me. I am not so sure about HBOCodeLabs#4
It should be fine, I'm just not super thrilled about changing static methods to
be instance methods for mocking purposes. I don't know of a better way to do
it, so please through up a pull request and we can discuss it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
