[
https://issues.apache.org/jira/browse/STORM-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306792#comment-14306792
]
ASF GitHub Bot commented on STORM-658:
--------------------------------------
GitHub user caofangkun opened a pull request:
https://github.com/apache/storm/pull/417
STORM-658:when config topology.acker.executors is null, should not start
acker bolts
Before the patch:
After the patch:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/caofangkun/apache-storm storm-658
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/417.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #417
----
commit 6c04e1bea802d28ae92a234ddbaad2c1ed0a6835
Author: caofangkun <[email protected]>
Date: 2015-01-23T01:28:46Z
Merge pull request #4 from apache/master
Merger from apache/storm to caofangkun/apache-storm
commit d8c98cb1846bd07aef558bde410607b923aa5c1e
Author: caofangkun <[email protected]>
Date: 2015-02-04T01:09:22Z
Merge pull request #5 from apache/master
Merge from apache/storm to caofangkun/apache-storm
commit 4889f5249bbfa7e11195d55e59dbd8b6afc099ad
Author: caofangkun <[email protected]>
Date: 2015-02-05T07:44:00Z
STORM-658:when config topology.acker.executors is null, should not start
acker bolts
----
> config topology.acker.executors default value is null and then should not
> start acker bolts
> -------------------------------------------------------------------------------------------
>
> Key: STORM-658
> URL: https://issues.apache.org/jira/browse/STORM-658
> Project: Apache Storm
> Issue Type: Bug
> Reporter: caofangkun
> Assignee: caofangkun
> Priority: Minor
> Attachments: executors num is wrong.png, is null.png
>
>
> See Code:
> https://github.com/caofangkun/apache-storm/blob/master/storm-core/src/clj/backtype/storm/daemon/common.clj#L315
> Config "topology.acker.executors" default value is null
> then acker executors will be same as "topology.workers"
> $ storm jar storm-starter-0.10.0-SNAPSHOT.jar
> storm.starter.ExclamationTopology ExclamationTopology
> Executors show up as 18 executors = 10(word) + 3(exclaim1) + 2(exclaim2) +
> 3(acker bolt)
> But the 3 acker bolt executors will not be used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
