[
https://issues.apache.org/jira/browse/STORM-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307555#comment-14307555
]
ASF GitHub Bot commented on STORM-658:
--------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/417#discussion_r24178855
--- Diff: storm-core/src/clj/backtype/storm/daemon/common.clj ---
@@ -312,7 +312,7 @@
))
(defn has-ackers? [storm-conf]
- (or (nil? (storm-conf TOPOLOGY-ACKER-EXECUTORS)) (> (storm-conf
TOPOLOGY-ACKER-EXECUTORS) 0)))
+ (and (not (nil? (storm-conf TOPOLOGY-ACKER-EXECUTORS))) (> (storm-conf
TOPOLOGY-ACKER-EXECUTORS) 0)))
--- End diff --
Or leave out both `not` and `nil`? Would that also work here?
> config topology.acker.executors default value is null and then should not
> start acker bolts
> -------------------------------------------------------------------------------------------
>
> Key: STORM-658
> URL: https://issues.apache.org/jira/browse/STORM-658
> Project: Apache Storm
> Issue Type: Bug
> Reporter: caofangkun
> Assignee: caofangkun
> Priority: Minor
> Attachments: executors num is wrong.png, is null.png
>
>
> See Code:
> https://github.com/caofangkun/apache-storm/blob/master/storm-core/src/clj/backtype/storm/daemon/common.clj#L315
> Config "topology.acker.executors" default value is null
> then acker executors will be same as "topology.workers"
> $ storm jar storm-starter-0.10.0-SNAPSHOT.jar
> storm.starter.ExclamationTopology ExclamationTopology
> Executors show up as 18 executors = 10(word) + 3(exclaim1) + 2(exclaim2) +
> 3(acker bolt)
> But the 3 acker bolt executors will not be used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
