[ 
https://issues.apache.org/jira/browse/STORM-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328339#comment-14328339
 ] 

ASF GitHub Bot commented on STORM-681:
--------------------------------------

Github user Lewuathe commented on the pull request:

    https://github.com/apache/storm/pull/436#issuecomment-75162992
  
    @Parth-Brahmbhatt Yes, I'm not sure too. But I think it is better to 
include the files generated by new `genthrift.sh` script in order to keep and 
confirm whole source code consistency.


> Auto insert license header with genthrift.sh
> --------------------------------------------
>
>                 Key: STORM-681
>                 URL: https://issues.apache.org/jira/browse/STORM-681
>             Project: Apache Storm
>          Issue Type: Improvement
>    Affects Versions: 0.10.0, 0.9.3-rc2
>            Reporter: Kai Sasaki
>            Assignee: Kai Sasaki
>            Priority: Minor
>              Labels: documentaion, thrift
>
> Current genthrift.sh does not insert license headers into generated source 
> codes. These java codes and python codes should have license headers. 
> And documentation about this command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to