[
https://issues.apache.org/jira/browse/STORM-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357257#comment-14357257
]
ASF GitHub Bot commented on STORM-681:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/436#discussion_r26235414
--- Diff: storm-core/src/genthrift.sh ---
@@ -17,6 +17,16 @@
rm -rf gen-javabean gen-py py
rm -rf jvm/backtype/storm/generated
thrift7 --gen java:beans,hashcode,nocamel --gen py:utf8strings storm.thrift
+for file in gen-javabean/backtype/storm/generated/* ; do
+ cat java_license_header.txt ${file} > ${file}.tmp
+ mv ${file}.tmp ${file}
+done
+cat py_license_header.txt gen-py/__init__.py > gen-py/__init__.py.tmp
+mv gen-py/__init__.py.tmp gen-py/__init__.py
+for file in gen-py/storm/* ; do
+ cat py_license_header.txt ${file} > ${file}.tmp
+ mv ${file}.tmp ${file}
--- End diff --
Could we include a `-f` on the mv command? I know a lot of us have mv
configured as an alias to `mv -i` to avoid unexpected overwrites and this would
cause problems.
> Auto insert license header with genthrift.sh
> --------------------------------------------
>
> Key: STORM-681
> URL: https://issues.apache.org/jira/browse/STORM-681
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.10.0, 0.9.3-rc2
> Reporter: Kai Sasaki
> Assignee: Kai Sasaki
> Priority: Minor
> Labels: documentaion, thrift
>
> Current genthrift.sh does not insert license headers into generated source
> codes. These java codes and python codes should have license headers.
> And documentation about this command.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
