[
https://issues.apache.org/jira/browse/STORM-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336600#comment-14336600
]
ASF GitHub Bot commented on STORM-671:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/442#discussion_r25346357
--- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
@@ -410,7 +410,11 @@
(disruptor/clojure-handler
(fn [tuple-batch sequence-id end-of-batch?]
(fast-list-iter [[task-id msg] tuple-batch]
- (let [^TupleImpl tuple (if (instance? Tuple msg) msg
(.deserialize deserializer msg))]
+ (let [[deserialize-time ^TupleImpl tuple] (if (instance? Tuple
msg) [0.0 msg] (with-time (.deserialize deserializer msg)))]
--- End diff --
In all other cases the timings were sampled (we didn't measure everything).
Not totally sure if we can do the same thing here or not.
> Measure tuple serialization/deserialization latency.
> ----------------------------------------------------
>
> Key: STORM-671
> URL: https://issues.apache.org/jira/browse/STORM-671
> Project: Apache Storm
> Issue Type: New Feature
> Reporter: Robert Joseph Evans
> Assignee: Kai Sasaki
>
> Some times the serialization/deserialization cost can be very high, and it is
> not currently measured anywhere in storm. We should measure it, at least in
> a similar way to how we do execute and process latency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
