[
https://issues.apache.org/jira/browse/STORM-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336602#comment-14336602
]
ASF GitHub Bot commented on STORM-671:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/442#discussion_r25346450
--- Diff: storm-core/src/clj/backtype/storm/stats.clj ---
@@ -164,13 +164,13 @@
(def COMMON-FIELDS [:emitted :transferred])
(defrecord CommonStats [emitted transferred rate])
-(def BOLT-FIELDS [:acked :failed :process-latencies :executed
:execute-latencies])
+(def BOLT-FIELDS [:acked :failed :process-latencies :executed
:execute-latencies :deserialize-time])
;;acked and failed count individual tuples
-(defrecord BoltExecutorStats [common acked failed process-latencies
executed execute-latencies])
+(defrecord BoltExecutorStats [common acked failed process-latencies
executed execute-latencies deserialize-time])
-(def SPOUT-FIELDS [:acked :failed :complete-latencies])
+(def SPOUT-FIELDS [:acked :failed :complete-latencies :deserialize-time])
--- End diff --
Are we even collecting de-serialize time for the spout? I didn't see it
anywhere.
> Measure tuple serialization/deserialization latency.
> ----------------------------------------------------
>
> Key: STORM-671
> URL: https://issues.apache.org/jira/browse/STORM-671
> Project: Apache Storm
> Issue Type: New Feature
> Reporter: Robert Joseph Evans
> Assignee: Kai Sasaki
>
> Some times the serialization/deserialization cost can be very high, and it is
> not currently measured anywhere in storm. We should measure it, at least in
> a similar way to how we do execute and process latency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
