[ 
https://issues.apache.org/jira/browse/STORM-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367676#comment-14367676
 ] 

ASF GitHub Bot commented on STORM-712:
--------------------------------------

GitHub user kishorvpatil opened a pull request:

    https://github.com/apache/storm/pull/468

    [STORM-712] Storm daemons shutdown if OutOfMemoryError occurs in any thread 

    - Creating `ExtendedThreadPoolExecutor` to pass uncaughtExceptions as part 
of `afterExecute`
    - All daemon main threads set `uncaughtExceptionHandler`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kishorvpatil/incubator-storm storm712

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/468.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #468
    
----
commit 58da2016157c1c358f70cf0aceca8b9c56cffb0c
Author: Kishor Patil <[email protected]>
Date:   2015-02-19T22:51:40Z

    Nimbus should shutdown on OOM across any thread
    
    Conflicts:
        storm-core/src/clj/backtype/storm/util.clj
        storm-core/src/jvm/backtype/storm/utils/Utils.java

commit 720a93ee92903d4ad4c4ab299042624fe4202b37
Author: Kishor Patil <[email protected]>
Date:   2015-02-20T23:43:19Z

    Adding license, formatting and improving comments
    
    Conflicts:
        storm-core/src/jvm/backtype/storm/utils/Utils.java

commit 323534097617d44e263c52c27dcb6da1b418816f
Author: Kishor Patil <[email protected]>
Date:   2015-02-23T21:08:08Z

    Minor comment fix

commit 9ee8718029b79b984e57f7624709d44e4703f400
Author: Kishor Patil <[email protected]>
Date:   2015-03-17T15:00:53Z

    Daemons should shutdown on OOM across any thread

commit 5d6b62ba49609052426509d04ef8096b2c3dbd46
Author: Kishor Patil <[email protected]>
Date:   2015-03-18T17:59:45Z

    Remove unwanted import from Utils.java

----


> Storm daemons must shutdown JVM in case of OOM in any thread
> ------------------------------------------------------------
>
>                 Key: STORM-712
>                 URL: https://issues.apache.org/jira/browse/STORM-712
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Kishor Patil
>
> In case of OutOfMemoryError in any thread, it needs to trigger immediate 
> shutdown of the server. I can be done by using 
> setDefaultUncaughtExceptionHandler on threads being created. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to