[
https://issues.apache.org/jira/browse/STORM-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382189#comment-14382189
]
ASF GitHub Bot commented on STORM-712:
--------------------------------------
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/468#discussion_r27231134
--- Diff: storm-core/src/jvm/backtype/storm/drpc/DRPCSpout.java ---
@@ -129,7 +133,9 @@ private void checkFutures() {
public void open(Map conf, TopologyContext context,
SpoutOutputCollector collector) {
_collector = collector;
if(_local_drpc_id==null) {
- _backround = Executors.newCachedThreadPool();
+ _backround = new ExtendedThreadPoolExecutor(0,
Integer.MAX_VALUE,
+ 60L, TimeUnit.SECONDS,
+ new SynchronousQueue<Runnable>());
--- End diff --
You swapped out thread pool that caches threads with implementation that
does proper exception handling, are you sure there won't be any performance
degradations?
> Storm daemons must shutdown JVM in case of OOM in any thread
> ------------------------------------------------------------
>
> Key: STORM-712
> URL: https://issues.apache.org/jira/browse/STORM-712
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Kishor Patil
>
> In case of OutOfMemoryError in any thread, it needs to trigger immediate
> shutdown of the server. I can be done by using
> setDefaultUncaughtExceptionHandler on threads being created.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
