Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/475#discussion_r27186979
--- Diff:
storm-core/src/jvm/backtype/storm/transactional/state/TransactionalState.java
---
@@ -59,7 +59,8 @@ protected TransactionalState(Map conf, String id, Map
componentConf, String subr
.get(Config.TOPOLOGY_KRYO_REGISTER));
}
String transactionalRoot =
(String)conf.get(Config.TRANSACTIONAL_ZOOKEEPER_ROOT);
- String rootDir = transactionalRoot + "/" + id + "/" + subroot;
+ String topologyName = (String)conf.get(Config.TOPOLOGY_NAME);
--- End diff --
What if topologyName is null?
Should we give these configs default valuesï¼
Something like:
```
String topologyName = Utils.parseString(conf.get(Config.TOPOLOGY_NAME),
"default-topology-name");
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
