Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/475#issuecomment-86539624
  
    This is the path I saw through the code.  Please let me know if I missed 
anything.
    
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/topology/state/TransactionalState.java#L53
    
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/spout/TridentSpoutCoordinator.java#L56
    
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/spout/TridentSpoutCoordinator.java#L48-51
    
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java#L160
    
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java#L278-282
    
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java#L71-76
    
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/TridentTopology.java#L403
    
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/planner/SpoutNode.java#L33-35
    
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/TridentTopology.java#L119-122
    
    I am a bit nervous about breaking backwards compatibility without a 
migration path.  I would be OK with the change if we had a tool that could 
upgrade/downgrade a trident topology state.  I suppose it would be OK to also 
have an option to not include the topology name, but I would prefer to not have 
to deal with that from a state perspective.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to