Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/468#discussion_r27230992
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -533,4 +533,16 @@ private static SerializationDelegate
getSerializationDelegate(Map stormConf) {
delegate.prepare(stormConf);
return delegate;
}
+
+ public static void handleUncaughtException(Throwable t) {
+ if(t!= null && t instanceof OutOfMemoryError) {
+ try {
+ System.err.println("Halting due to Out Of Memory Error..." +
Thread.currentThread().getName());
+ } catch (Throwable err) {
+ //Again we done want to exit because of logging issues.
+ }
+ Runtime.getRuntime().halt(-1);
+ }
+ }
--- End diff --
Why log only OOMs? Am I right that all other exceptions/errors will be
silently swallowed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
