Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/468#discussion_r27231134
--- Diff: storm-core/src/jvm/backtype/storm/drpc/DRPCSpout.java ---
@@ -129,7 +133,9 @@ private void checkFutures() {
public void open(Map conf, TopologyContext context,
SpoutOutputCollector collector) {
_collector = collector;
if(_local_drpc_id==null) {
- _backround = Executors.newCachedThreadPool();
+ _backround = new ExtendedThreadPoolExecutor(0,
Integer.MAX_VALUE,
+ 60L, TimeUnit.SECONDS,
+ new SynchronousQueue<Runnable>());
--- End diff --
You swapped out thread pool that caches threads with implementation that
does proper exception handling, are you sure there won't be any performance
degradations?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
