[
https://issues.apache.org/jira/browse/STORM-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483974#comment-14483974
]
ASF GitHub Bot commented on STORM-757:
--------------------------------------
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/508#issuecomment-90718587
LGTM. Great!
Btw, I feel it would be another chance of adopting CI (Jenkins, Travis, or
anything) to catch some bugs from each PR before merge.
> Simulated time can leak out on errors
> -------------------------------------
>
> Key: STORM-757
> URL: https://issues.apache.org/jira/browse/STORM-757
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
>
> with-simulated-time does not use try-finally so on any error simulated time
> can be left on in the tests leading to tests hanging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
