[
https://issues.apache.org/jira/browse/STORM-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486397#comment-14486397
]
ASF GitHub Bot commented on STORM-757:
--------------------------------------
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/508#issuecomment-91075470
@revans2 Regarding timeout, it would be better to use TEST-TIMEOUT-MS on
timeout value.
Just a two cents, wait-for-condition doesn't treat timeout so it could be
stuck.
So tests should use while-timeout unless wait-for-condition does take care
of timeout.
While while-timeout provides more informations on timeout, it would be
better for wait-for-condition use while-timeout, too.
> Simulated time can leak out on errors
> -------------------------------------
>
> Key: STORM-757
> URL: https://issues.apache.org/jira/browse/STORM-757
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
>
> with-simulated-time does not use try-finally so on any error simulated time
> can be left on in the tests leading to tests hanging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
