[ 
https://issues.apache.org/jira/browse/STORM-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485279#comment-14485279
 ] 

ASF GitHub Bot commented on STORM-483:
--------------------------------------

GitHub user zhuoliu opened a pull request:

    https://github.com/apache/storm/pull/516

    [STORM-483] extlib for external, extlib-daemon for daemo-only external

    1. Packaging creates two new directories named "extlib" and "extlib-daemon" 
for holding external jars, and daemons-only external jars, respectively.
    2. "bin/storm" takes the jars from the above two directories and optional 
external classpaths, and puts into classpath for launching exec_storm_class 
(for daemons).
    3. In supervisor, when launching a worker, worker-classpath is built from 
scratch (include extlib but not include extlib-daemon), rather than inherited 
from supervisor's current-classpath . This is for avoiding classpath leakage 
from daemons to workers.
    Thanks Robert and Naga's comments and proposal.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhuoliu/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/516.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #516
    
----
commit 05306d5053ff91bd323c4b54cd246c9f928ca339
Author: zhuol <[email protected]>
Date:   2015-04-08T13:57:31Z

    Deal with STORM-483 exlib issue

commit c106f1337f84cf7f46be0a133b3bd17b57412d3f
Author: zhuol <[email protected]>
Date:   2015-04-08T14:03:42Z

    Merge remote-tracking branch 'apache/master'

----


> extlib for external (contrib and/or 3rd party integration)
> ----------------------------------------------------------
>
>                 Key: STORM-483
>                 URL: https://issues.apache.org/jira/browse/STORM-483
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Naga Vijayapuram
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.9.3
>
>
> Proposing a dir (extlib) to hold jars for external (contrib and/or 3rd party 
> integration).  storm script can first pick up the jars in lib dir for 
> classpath, and then the jars in extlib dir.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to