[ 
https://issues.apache.org/jira/browse/STORM-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493162#comment-14493162
 ] 

ASF GitHub Bot commented on STORM-483:
--------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/516#discussion_r28283336
  
    --- Diff: bin/storm.py ---
    @@ -85,6 +85,10 @@ def init_storm_env():
     JAR_JVM_OPTS = shlex.split(os.getenv('STORM_JAR_JVM_OPTS', ''))
     JAVA_HOME = os.getenv('JAVA_HOME', None)
     JAVA_CMD = 'java' if not JAVA_HOME else os.path.join(JAVA_HOME, 'bin', 
'java')
    +NIMBUS_EXTRA_CLASSPATHS = os.getenv('NIMBUS_EXTRA_CLASSPATHS', None)
    +SUPERVISOR_EXTRA_CLASSPATHS = os.getenv('SUPERVISOR_EXTRA_CLASSPATHS', 
None)
    --- End diff --
    
    I don't see a reason to have NIMBUS and SUPERVISOR specific class paths 
options.  If you have a good use case, please let me know otherwise I would 
like to see them removed.


> extlib for external (contrib and/or 3rd party integration)
> ----------------------------------------------------------
>
>                 Key: STORM-483
>                 URL: https://issues.apache.org/jira/browse/STORM-483
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Naga Vijayapuram
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.9.3
>
>
> Proposing a dir (extlib) to hold jars for external (contrib and/or 3rd party 
> integration).  storm script can first pick up the jars in lib dir for 
> classpath, and then the jars in extlib dir.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to