[
https://issues.apache.org/jira/browse/STORM-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495168#comment-14495168
]
Parth Brahmbhatt commented on STORM-766:
----------------------------------------
Hi [~redsanket] , Welcome to the storm community and thanks for showing
interest to contribute. Sorry for not providing enough details on jira in first
place.
Storm will start supporting rolling upgrades in either version 0.10 or the next
version as most of our serialization has moved from java to thrift. Previous
version used java serialization which meant the entire cluster had to be
running on same version so it made sense to have a cluster version. With the
rolling upgrade this will change and different hosts in the cluster might be
running different version. It will be useful for admins to view what hosts are
on what versions.
To expose this information this jira proposes to expose the storm version in
supervisor summary. This means adding a verion string to this structure
https://github.com/apache/storm/blob/master/storm-core/src/storm.thrift#L150
and re-generating the thrift structure using
https://github.com/apache/storm/blob/master/storm-core/src/genthrift.sh.
Supervisors will also have to store this information in zookeeper so nimbus can
read this information so you will need to probably look into modifying
https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/daemon/supervisor.clj#L505
and
https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/cluster.clj#L397.
Once this data is stored in zookeeper nimbus needs to read it and populate the
SupervisorSummary instances with version
https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/daemon/nimbus.clj#L1250.
Finally the ui changes can be made here
https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/ui/core.clj#L571
and
https://github.com/apache/storm/blob/master/storm-core/src/ui/public/templates/index-page-template.html#L145.
Let me know if you need any more information and once again thanks for
considering to contribute.
> Supervisor summary should include the version.
> ----------------------------------------------
>
> Key: STORM-766
> URL: https://issues.apache.org/jira/browse/STORM-766
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Parth Brahmbhatt
> Assignee: Parth Brahmbhatt
> Priority: Minor
> Fix For: 0.10.0
>
>
> With the support for rolling upgrade, different nodes in the cluster can run
> different versions of storm. We should include the version in
> SupervisorSummary just like NimbusSummary so admins can identify nodes that
> needs upgrading/downgrading from UI.
> As part of this change I will also add a supervisor/log link in the ui.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
