[
https://issues.apache.org/jira/browse/STORM-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502869#comment-14502869
]
ASF GitHub Bot commented on STORM-766:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/529#discussion_r28690338
--- Diff: storm-core/src/clj/backtype/storm/converter.clj ---
@@ -23,7 +25,9 @@
(if (.get_used_ports supervisor-info) (into [] (.get_used_ports
supervisor-info)))
(if (.get_meta supervisor-info) (into [] (.get_meta
supervisor-info)))
(if (.get_scheduler_meta supervisor-info) (into {}
(.get_scheduler_meta supervisor-info)))
- (.get_uptime_secs supervisor-info))))
+ (.get_uptime_secs supervisor-info)
+ (.get_version supervisor-info);;log
--- End diff --
Please clean up the comment, not sure what ;;log means, and move the
closing ')' to this line
> Supervisor summary should include the version.
> ----------------------------------------------
>
> Key: STORM-766
> URL: https://issues.apache.org/jira/browse/STORM-766
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Parth Brahmbhatt
> Assignee: Sanket Chintapalli
> Priority: Minor
> Fix For: 0.10.0
>
>
> With the support for rolling upgrade, different nodes in the cluster can run
> different versions of storm. We should include the version in
> SupervisorSummary just like NimbusSummary so admins can identify nodes that
> needs upgrading/downgrading from UI.
> As part of this change I will also add a supervisor/log link in the ui.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
