[
https://issues.apache.org/jira/browse/STORM-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560025#comment-14560025
]
ASF GitHub Bot commented on STORM-821:
--------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/556#discussion_r31087238
--- Diff: external/storm-jdbc/README.md ---
@@ -17,11 +44,12 @@ The `getColumns()` method defines how a storm tuple
maps to a list of columns re
**The order of the returned list is important. The place holders in the
supplied queries are resolved in the same order as returned list.**
For example if the user supplied insert query is `insert into
user(user_id, user_name, create_date) values (?,?, now())` the 1st item
of the returned list of `getColumns` method will map to the 1st place
holder and the 2nd to the 2nd and so on. We do not parse
-the supplied queries to try and resolve place holder by column names.
+the supplied queries to try and resolve place holder by column names. Not
making any assumptions about the query syntax allows this connector
+to be used by some non-standard sql frameworks like Pheonix which only
supports upsert into.
### JdbcInsertBolt
-To use the `JdbcInsertBolt`, you construct an instance of it and specify a
configuration key in your storm config that holds the
-hikari configuration map and a `JdbcMapper` implementation that coverts
storm tuple to DB row. In addition, you must either supply
+To use the `JdbcInsertBolt`, you construct an instance of it by specifying
a `ConnectionProvider` implementation
+and a `JdbcMapper` implementation that coverts storm tuple to DB row. In
addition, you must either supply
--- End diff --
coverts -> converts
> storm-jdbc create a connection provider interface to decouple from hikariCP
> being the only connection pool implementation that can be used.
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: STORM-821
> URL: https://issues.apache.org/jira/browse/STORM-821
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.10.0
> Reporter: Parth Brahmbhatt
> Assignee: Parth Brahmbhatt
> Priority: Minor
> Fix For: 0.10.0
>
>
> The current implementation of storm-jdbc is couple with HikariCP
> configuration. We propose to remove this coupling by introducing a
> connectionProvider interface with a default HikariCP implementation. This
> will allow users to do their own connection pool management or chose a
> different connection pooling library.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
