[
https://issues.apache.org/jira/browse/STORM-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560034#comment-14560034
]
ASF GitHub Bot commented on STORM-821:
--------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/556#discussion_r31087884
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/mapper/SimpleJdbcMapper.java
---
@@ -33,9 +34,10 @@
private List<Column> schemaColumns;
- public SimpleJdbcMapper(String tableName, Map hikariConfigurationMap) {
+ public SimpleJdbcMapper(String tableName, Map<String, Object>
connectionProvideConfig, ConnectionProvider connectionProvider) {
--- End diff --
Seems like we don't need to connectionProvideConfig here for now.
> storm-jdbc create a connection provider interface to decouple from hikariCP
> being the only connection pool implementation that can be used.
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: STORM-821
> URL: https://issues.apache.org/jira/browse/STORM-821
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.10.0
> Reporter: Parth Brahmbhatt
> Assignee: Parth Brahmbhatt
> Priority: Minor
> Fix For: 0.10.0
>
>
> The current implementation of storm-jdbc is couple with HikariCP
> configuration. We propose to remove this coupling by introducing a
> connectionProvider interface with a default HikariCP implementation. This
> will allow users to do their own connection pool management or chose a
> different connection pooling library.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
