[
https://issues.apache.org/jira/browse/STORM-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567550#comment-14567550
]
ASF GitHub Bot commented on STORM-753:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/504#discussion_r31444080
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/Options.java
---
@@ -0,0 +1,33 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.redis.trident.state;
+
+import org.apache.storm.redis.common.mapper.RedisDataTypeDescription;
+import storm.trident.state.Serializer;
+
+import java.io.Serializable;
+
+public class Options<T> implements Serializable {
+ private static final RedisDataTypeDescription DEFAULT_REDIS_DATATYPE =
new RedisDataTypeDescription(RedisDataTypeDescription.RedisDataType.STRING);
+
+ public int localCacheSize = 1000;
+ public String globalKey = "$REDIS-MAP-STATE-GLOBAL";
+ KeyFactory keyFactory = null;
--- End diff --
Why is the key factory not public? Do we not want people to override it?
Do we want setters available for these instead of just public data values?
> [storm-redis] Let Redis*StateUpdater to have additional mapper - converting
> Redis key/value to Storm Values
> -----------------------------------------------------------------------------------------------------------
>
> Key: STORM-753
> URL: https://issues.apache.org/jira/browse/STORM-753
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.10.0, 0.11.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> https://issues.apache.org/jira/browse/STORM-723?focusedCommentId=14381626&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14381626
> Currently Redis*StateUpdater use key prefix to let users customize key name.
> Since it's less powerful, how about having 2 mappers which one is for
> converting tuple to key/value, and another one is for converting value from
> Redis to Storm Values?
> You can refer
> https://github.com/apache/storm/blob/master/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseState.java.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
