[
https://issues.apache.org/jira/browse/STORM-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568100#comment-14568100
]
ASF GitHub Bot commented on STORM-753:
--------------------------------------
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/504#issuecomment-107725417
@revans2
Thanks for your careful review! I addressed all of your comments.
I have been using private / protected field and public getter/setter unless
it has any special reasons.
Storm-redis has several 'default' or 'public' fields in some classes
including Options which I'd like to restrict.
I'll file on new issue addressing it.
Since most of classes in storm-redis doesn't have javadoc, it would be
better to treat it to new issue.
I'll file on new issue for javadoc, too.
> [storm-redis] Let Redis*StateUpdater to have additional mapper - converting
> Redis key/value to Storm Values
> -----------------------------------------------------------------------------------------------------------
>
> Key: STORM-753
> URL: https://issues.apache.org/jira/browse/STORM-753
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.10.0, 0.11.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> https://issues.apache.org/jira/browse/STORM-723?focusedCommentId=14381626&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14381626
> Currently Redis*StateUpdater use key prefix to let users customize key name.
> Since it's less powerful, how about having 2 mappers which one is for
> converting tuple to key/value, and another one is for converting value from
> Redis to Storm Values?
> You can refer
> https://github.com/apache/storm/blob/master/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseState.java.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
