Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/504#issuecomment-107631879
In general it looks good. I would like to see the docs updated to match
the test code, and I would like to understand why options.keyFactory is not
public.
I would also love to see some javadocs for the classes being added,
although that is not strictly necessary. Great job by the way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
