Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/504#issuecomment-107725417
@revans2
Thanks for your careful review! I addressed all of your comments.
I have been using private / protected field and public getter/setter unless
it has any special reasons.
Storm-redis has several 'default' or 'public' fields in some classes
including Options which I'd like to restrict.
I'll file on new issue addressing it.
Since most of classes in storm-redis doesn't have javadoc, it would be
better to treat it to new issue.
I'll file on new issue for javadoc, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
