Unfortunately I found a bug from uploadTopology REST API.
(Sorry I participated to review that feature but I didn't think about
multiple arguments.)

Here's my checklist.

- test passed : OK
-- extract source tar
-- build via "mvn clean install”
- topology tests via storm-starter : OK
-- run WordCounts and RollingTopWords, local mode and remote mode
- test REST APIs (upload / activate / deactivate / kill) : FAIL
-- activate / deactivate / kill works fine
-- upload topology fails with multiple arguments
-- filed issue to https://issues.apache.org/jira/browse/STORM-853

Uploading topology is a new feature, so I'd like to include fixed version
of feature to 0.10.0.
(https://github.com/apache/storm/pull/581 is ready for the fix.)

Btw, STORM-813 (correcting storm-starter's README) is related to 0.10.0 so
I'd like to include it, but just applying it to Github repo could be
acceptable.

Thanks!
Jungtaek Lim (HeartSaVioR)

2015-06-06 7:59 GMT+09:00 Kishorkumar Patil <[email protected]>:

> +1. LGTM. I built and ran some tests.
> -Kishor
>
>
>
>      On Friday, June 5, 2015 4:38 PM, P. Taylor Goetz <[email protected]>
> wrote:
>
>
>  The v0.10.0 tag was already updates as part of the release process. The
> release candidate was built from that tag.
>
> -Taylor
>
>
> > On Jun 5, 2015, at 5:16 PM, Bobby Evans <[email protected]>
> wrote:
> >
> > +1
> > I checked out the code, built it and ran the tests.  Once the vote
> passes we need to be sure to update the v0.10.0 tag to point to the correct
> release version in git.
> >  - Bobby
> >
> >
> >
> >    On Friday, June 5, 2015 2:54 PM, P. Taylor Goetz <[email protected]>
> wrote:
> >
> >
> > This is a call to vote on releasing Apache Storm 0.10.0 (rc2).
> >
> > Full list of changes in this release:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=CHANGELOG.md;hb=33d6c74041c286eb8b30b26bd0d6a76aa81a667f
> >
> > The tag/commit to be voted upon is v0.10.0:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=b8aba80e2259f3e12493a871b1af4f69864d40c2;hb=33d6c74041c286eb8b30b26bd0d6a76aa81a667f
> >
> > The source archive being voted upon can be found here:
> >
> >
> http://people.apache.org/~ptgoetz/apache-storm-0.10.0-rc2/apache-storm-0.10.0-src.tar.gz
> >
> > Other release files, signatures and digests can be found here:
> >
> > http://people.apache.org/~ptgoetz/apache-storm-0.10.0-rc2/
> >
> > The release artifacts are signed with the following key:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd
> >
> > The Nexus staging repository for this release is:
> >
> > https://repository.apache.org/content/repositories/orgapachestorm-1016
> >
> > Please vote on releasing this package as Apache Storm 0.10.0.
> >
> > When voting, please list the actions taken to verify the release.
> >
> > This vote will be open for at least 72 hours.
> >
> > [ ] +1 Release this package as Apache Storm 0.10.0
> > [ ]  0 No opinion
> > [ ] -1 Do not release this package because...
> >
> > Thanks,
> > Taylor
> >
>
>
>



-- 
Name : 임 정택
Blog : http://www.heartsavior.net / http://dev.heartsavior.net
Twitter : http://twitter.com/heartsavior
LinkedIn : http://www.linkedin.com/in/heartsavior

Reply via email to