OK, I see your point. I know Storm 0.10.0 is postponed several times, and it already has very huge changeset. I don't mean to say we have to postpone again, just want to hear opinion that we're OK to release with know issue, or fix it ASAP and reopen vote.
I'm +1 (non-binding) with describing known issue to release note so that users don't meet strange behavior without information. Thanks! Jungtaek Lim (HeartSaVioR) 2015년 6월 9일 화요일, P. Taylor Goetz<ptgo...@gmail.com>님이 작성한 메시지: > I’m +1 for moving forward with the current release candidate. I think we > can address STORM-813 in a follow-up bug fix/maintenance release (soon). > > In the big picture, the REST upload API is just one of many, many > features/improvements added in 0.10.0, and we’ve not leveraged it in any > way yet (i.e. in Storm UI). I don’t think it should block the release. > > -Taylor > > On Jun 6, 2015, at 2:16 AM, 임정택 <kabh...@gmail.com <javascript:;>> wrote: > > > Unfortunately I found a bug from uploadTopology REST API. > > (Sorry I participated to review that feature but I didn't think about > > multiple arguments.) > > > > Here's my checklist. > > > > - test passed : OK > > -- extract source tar > > -- build via "mvn clean install” > > - topology tests via storm-starter : OK > > -- run WordCounts and RollingTopWords, local mode and remote mode > > - test REST APIs (upload / activate / deactivate / kill) : FAIL > > -- activate / deactivate / kill works fine > > -- upload topology fails with multiple arguments > > -- filed issue to https://issues.apache.org/jira/browse/STORM-853 > > > > Uploading topology is a new feature, so I'd like to include fixed version > > of feature to 0.10.0. > > (https://github.com/apache/storm/pull/581 is ready for the fix.) > > > > Btw, STORM-813 (correcting storm-starter's README) is related to 0.10.0 > so > > I'd like to include it, but just applying it to Github repo could be > > acceptable. > > > > Thanks! > > Jungtaek Lim (HeartSaVioR) > > > > 2015-06-06 7:59 GMT+09:00 Kishorkumar Patil <kpa...@yahoo-inc.com.invalid > >: > > > >> +1. LGTM. I built and ran some tests. > >> -Kishor > >> > >> > >> > >> On Friday, June 5, 2015 4:38 PM, P. Taylor Goetz <ptgo...@gmail.com > <javascript:;>> > >> wrote: > >> > >> > >> The v0.10.0 tag was already updates as part of the release process. The > >> release candidate was built from that tag. > >> > >> -Taylor > >> > >> > >>> On Jun 5, 2015, at 5:16 PM, Bobby Evans <ev...@yahoo-inc.com.INVALID> > >> wrote: > >>> > >>> +1 > >>> I checked out the code, built it and ran the tests. Once the vote > >> passes we need to be sure to update the v0.10.0 tag to point to the > correct > >> release version in git. > >>> - Bobby > >>> > >>> > >>> > >>> On Friday, June 5, 2015 2:54 PM, P. Taylor Goetz <ptgo...@apache.org > <javascript:;>> > >> wrote: > >>> > >>> > >>> This is a call to vote on releasing Apache Storm 0.10.0 (rc2). > >>> > >>> Full list of changes in this release: > >>> > >>> > >> > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=CHANGELOG.md;hb=33d6c74041c286eb8b30b26bd0d6a76aa81a667f > >>> > >>> The tag/commit to be voted upon is v0.10.0: > >>> > >>> > >> > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=b8aba80e2259f3e12493a871b1af4f69864d40c2;hb=33d6c74041c286eb8b30b26bd0d6a76aa81a667f > >>> > >>> The source archive being voted upon can be found here: > >>> > >>> > >> > http://people.apache.org/~ptgoetz/apache-storm-0.10.0-rc2/apache-storm-0.10.0-src.tar.gz > >>> > >>> Other release files, signatures and digests can be found here: > >>> > >>> http://people.apache.org/~ptgoetz/apache-storm-0.10.0-rc2/ > >>> > >>> The release artifacts are signed with the following key: > >>> > >>> > >> > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > >>> > >>> The Nexus staging repository for this release is: > >>> > >>> https://repository.apache.org/content/repositories/orgapachestorm-1016 > >>> > >>> Please vote on releasing this package as Apache Storm 0.10.0. > >>> > >>> When voting, please list the actions taken to verify the release. > >>> > >>> This vote will be open for at least 72 hours. > >>> > >>> [ ] +1 Release this package as Apache Storm 0.10.0 > >>> [ ] 0 No opinion > >>> [ ] -1 Do not release this package because... > >>> > >>> Thanks, > >>> Taylor > >>> > >> > >> > >> > > > > > > > > -- > > Name : 임 정택 > > Blog : http://www.heartsavior.net / http://dev.heartsavior.net > > Twitter : http://twitter.com/heartsavior > > LinkedIn : http://www.linkedin.com/in/heartsavior > > -- Name : 임 정택 Blog : http://www.heartsavior.net / http://dev.heartsavior.net Twitter : http://twitter.com/heartsavior LinkedIn : http://www.linkedin.com/in/heartsavior
