[ 
https://issues.apache.org/jira/browse/STORM-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602360#comment-14602360
 ] 

ASF GitHub Bot commented on STORM-913:
--------------------------------------

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/605#discussion_r33326992
  
    --- Diff: storm-core/src/clj/backtype/storm/zookeeper.clj ---
    @@ -103,11 +103,14 @@
          (catch Exception e (throw (wrap-in-runtime e))))))
     
     (defnk delete-node
    --- End diff --
    
    It silently does nothing when path is not exist, but it was throwing 
NoNodeException when force is false, and default is false.
    Only delete-recursive calls delete-node with force = true, and any other 
usages are using default.
    
    In short, it doesn't show same behavior between two.


> Use Curator's delete().deletingChildrenIfNeeded() instead of 
> zk/delete-recursive 
> ---------------------------------------------------------------------------------
>
>                 Key: STORM-913
>                 URL: https://issues.apache.org/jira/browse/STORM-913
>             Project: Apache Storm
>          Issue Type: Improvement
>    Affects Versions: 0.11.0
>            Reporter: caofangkun
>            Assignee: caofangkun
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to