[
https://issues.apache.org/jira/browse/STORM-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629792#comment-14629792
]
ASF GitHub Bot commented on STORM-913:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/615#issuecomment-121968459
@caofangkun I am a bit nervous about this change. We are changing code
that had the option to auto create parents or auto-delete parents to not have
that option any more. Yes this makes it simpler if you don't know if a
directory was created or not, but it becomes a problem in the case of ACLs. If
we are running with security and we create a parent directory it may end up
with the incorrect ACLs.
I would also want to see where each of these functions are called and see
if they all have :force turned on or not. If they do the parameter is
unneeded. If they do not I want to understand why they don't
> Use Curator's delete().deletingChildrenIfNeeded() instead of
> zk/delete-recursive
> ---------------------------------------------------------------------------------
>
> Key: STORM-913
> URL: https://issues.apache.org/jira/browse/STORM-913
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.11.0
> Reporter: caofangkun
> Assignee: caofangkun
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
