[
https://issues.apache.org/jira/browse/STORM-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613232#comment-14613232
]
ASF GitHub Bot commented on STORM-826:
--------------------------------------
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/572#discussion_r33868970
--- Diff: external/storm-kafka/src/jvm/storm/kafka/bolt/KafkaBolt.java ---
@@ -102,12 +114,40 @@ public void execute(Tuple input) {
key = mapper.getKeyFromTuple(input);
message = mapper.getMessageFromTuple(input);
topic = topicSelector.getTopic(input);
- if(topic != null ) {
- producer.send(new KeyedMessage<K, V>(topic, key, message));
+ if (topic != null ) {
+ Callback callback = null;
+
+ if (!fireAndForget && async) {
+ callback = new Callback() {
+ @Override
+ public void onCompletion(RecordMetadata ignored,
Exception e) {
+ synchronized (collector) {
--- End diff --
Most of the storm user facing components usually thought as a single thread
actors. Are you sure you want to break this abstraction?
> As a storm developer I’d like to use the new kafka producer API to reduce
> dependencies and use long term supported kafka apis
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: STORM-826
> URL: https://issues.apache.org/jira/browse/STORM-826
> Project: Apache Storm
> Issue Type: Story
> Components: storm-kafka
> Reporter: Thomas Becker
> Assignee: Zhuo Liu
> Fix For: 0.11.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
