[
https://issues.apache.org/jira/browse/STORM-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601222#comment-14601222
]
ASF GitHub Bot commented on STORM-826:
--------------------------------------
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/storm/pull/572#discussion_r33256376
--- Diff: external/storm-kafka/src/jvm/storm/kafka/bolt/KafkaBolt.java ---
@@ -53,10 +55,13 @@
public static final String TOPIC = "topic";
public static final String KAFKA_BROKER_PROPERTIES =
"kafka.broker.properties";
- private Producer<K, V> producer;
+ private KafkaProducer<K, V> producer;
private OutputCollector collector;
private TupleToKafkaMapper<K,V> mapper;
private KafkaTopicSelector topicSelector;
+ /* With default setting for fireAndForget and async, the callback is
called when sending succeed */
+ private boolean fireAndForget = false; /* by setting as true, each
send immediately gets acked by collector */
--- End diff --
lets clarify this comment saying it doesn't wait at all for kafka to ack.
ack setting doesn't matter if this is used.
> As a storm developer I’d like to use the new kafka producer API to reduce
> dependencies and use long term supported kafka apis
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: STORM-826
> URL: https://issues.apache.org/jira/browse/STORM-826
> Project: Apache Storm
> Issue Type: Story
> Components: storm-kafka
> Reporter: Thomas Becker
> Assignee: Zhuo Liu
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
