[
https://issues.apache.org/jira/browse/STORM-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627573#comment-14627573
]
ASF GitHub Bot commented on STORM-918:
--------------------------------------
GitHub user bourneagain opened a pull request:
https://github.com/apache/storm/pull/632
STORM-918 Storm CLI could validate arguments/print usage
Storm commands that mandate proper args to be passed would now throw
the function's doc string as help rather than exiting out with error after
creating the JVM
process.
Example :
./storm kill
Syntax: [storm kill topology-name [-w wait-time-secs]]
Kills the topology with the name topology-name. Storm will
first deactivate the topology's spouts for the duration of
the topology's message timeout to allow all messages currently
being processed to finish processing. Storm will then shutdown
the workers and clean up their state. You can override the length
of time Storm waits between deactivation and shutdown with the -w flag.
./storm get-errors
Syntax: [storm get-errors topology-name]
Get the latest error from the running topology. The returned result
contains
the key value pairs for component-name and component-error for the
components in error.
The result is returned in json format.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bourneagain/storm STORM-918
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/632.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #632
----
commit fc09bf07afca95a82cbdbb4f10d47c56bdff3918
Author: Shyam Rajendran <[email protected]>
Date: 2015-07-15T05:42:41Z
STORM-918 Storm CLI could validate arguments/print usage
Storm commands that mandate proper args to be passed would not thrown
the function doc string rather than errorring out after creating the JVM
process.
----
> Storm CLI could validate arguments/print usage
> ----------------------------------------------
>
> Key: STORM-918
> URL: https://issues.apache.org/jira/browse/STORM-918
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.10.0
> Reporter: Derek Dagit
> Assignee: Shyam Rajendran
> Priority: Minor
> Labels: Newbie
>
> It would be nice if the storm CLI printed usage information if arguments are
> missing.
> For example, when omitting the argument to the kill sub-command, a JVM is
> launched and an exception complaining that a topology named 'nil' is not
> alive.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
