[ 
https://issues.apache.org/jira/browse/STORM-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628450#comment-14628450
 ] 

ASF GitHub Bot commented on STORM-918:
--------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/632#issuecomment-121692328
  
    @bourneagain I really don't like the idea of pulling data out of the call 
stack to check for arguments.  If we are going to check for arguments lets 
check for them in each of the functions, instead of in exec_storm_class.  Yes 
it is more code, but I think it is cleaner, and more maintainable.


> Storm CLI could validate arguments/print usage
> ----------------------------------------------
>
>                 Key: STORM-918
>                 URL: https://issues.apache.org/jira/browse/STORM-918
>             Project: Apache Storm
>          Issue Type: Improvement
>    Affects Versions: 0.10.0
>            Reporter: Derek Dagit
>            Assignee: Shyam Rajendran
>            Priority: Minor
>              Labels: Newbie
>
> It would be nice if the storm CLI printed usage information if arguments are 
> missing.
> For example, when omitting the argument to the kill sub-command, a JVM is 
> launched and an exception complaining that a topology named 'nil' is not 
> alive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to