Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/648#discussion_r35406122
--- Diff: storm-core/src/jvm/backtype/storm/utils/DRPCClient.java ---
@@ -46,7 +46,22 @@ public DRPCClient(Map conf, String host, int port,
Integer timeout) throws TTran
this.port = port;
this.client = new DistributedRPC.Client(_protocol);
}
-
+
+ public static DistributedRPC.Client getConfiguredDRPCClient(String
host, int port) {
+ return getConfiguredDRPCClient(null, host, port);
+ }
+
+ public static DistributedRPC.Client getConfiguredDRPCClient(Map conf,
String host, int port) {
+ try {
+ Map fullConf = Utils.readStormConfig();
+ if (conf != null) {
+ fullConf.putAll(conf);
+ }
+ return new DRPCClient(conf, host, port).getClient();
--- End diff --
shoud be ```return new DRPCClient(fullConf, host, port).getClient();```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
