Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/648#discussion_r35406230
--- Diff: storm-core/src/jvm/backtype/storm/utils/NimbusClient.java ---
@@ -30,11 +30,18 @@
private Nimbus.Client _client;
private static final Logger LOG =
LoggerFactory.getLogger(NimbusClient.class);
+ public static NimbusClient getConfiguredClient() {
+ return getConfiguredClient(null);
+ }
public static NimbusClient getConfiguredClient(Map conf) {
- try {
- String nimbusHost = (String) conf.get(Config.NIMBUS_HOST);
- return new NimbusClient(conf, nimbusHost);
+ try {
+ Map fullConf = Utils.readStormConfig();
+ if (conf != null) {
+ fullConf.putAll(conf);
+ }
+ String nimbusHost = (String) conf.get(Config.NIMBUS_HOST);
+ return new NimbusClient(conf, nimbusHost);
--- End diff --
should be
```
String nimbusHost = (String) fullConf.get(Config.NIMBUS_HOST);
return new NimbusClient(fullConf, nimbusHost);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
