Github user YvonneIronberg commented on a diff in the pull request:

    https://github.com/apache/storm/pull/684#discussion_r37039905
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
    @@ -661,8 +661,8 @@
               storm-conf-file (System/getProperty "storm.conf.file")
               storm-log-dir (or (System/getProperty "storm.log.dir") (str 
storm-home file-path-separator "logs"))
               storm-conf (read-storm-config)
    -          storm-log-conf-dir (storm-conf "storm.logback.conf.dir")
    -          storm-logback-conf-dir (or storm-log-conf-dir (str storm-home 
file-path-separator "log4j2"))
    +          storm-log-conf-dir (storm-conf "storm.log4j2.conf.dir")
    --- End diff --
    
    Thanks for the review. Sure. Updated the patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to