Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/684#discussion_r37120357
--- Diff: bin/storm-config.cmd ---
@@ -83,10 +83,10 @@ if not defined STORM_LOG_DIR (
)
@rem
-@rem retrieve storm.logback.conf.dir from conf file
+@rem retrieve storm.log4j2.conf.dir from conf file
@rem
-"%JAVA%" -client -Dstorm.options= -Dstorm.conf.file= -cp "%CLASSPATH%"
backtype.storm.command.config_value storm.logback.conf.dir > %CMD_TEMP_FILE%
+"%JAVA%" -client -Dstorm.options= -Dstorm.conf.file= -cp "%CLASSPATH%"
backtype.storm.command.config_value storm.log4j2.conf.dir > %CMD_TEMP_FILE%
--- End diff --
I was looking around and found other usages of LOCKBACK in the
storm-config.cmd file. May as well change those while we are changing the
others.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
